-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semrush move links and link params to client side and tests #21865
Merged
pls78
merged 5 commits into
trunk
from
semrush-move-links-and-link-params-to-client-side
Dec 20, 2024
Merged
Semrush move links and link params to client side and tests #21865
pls78
merged 5 commits into
trunk
from
semrush-move-links-and-link-params-to-client-side
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vraja-pro
added
the
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
label
Nov 27, 2024
Pull Request Test Coverage Report for Build fd3d95d539ee78e702f644a471186b103d295a2fWarning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
pls78
force-pushed
the
feature/plugin-fixes
branch
from
December 4, 2024 13:48
ce4d990
to
3997998
Compare
enricobattocchi
force-pushed
the
feature/plugin-fixes
branch
from
December 6, 2024 11:07
3997998
to
860c1a6
Compare
vraja-pro
force-pushed
the
semrush-move-links-and-link-params-to-client-side
branch
2 times, most recently
from
December 6, 2024 11:35
6302a1b
to
39c152f
Compare
vraja-pro
force-pushed
the
semrush-move-links-and-link-params-to-client-side
branch
from
December 13, 2024 08:08
39c152f
to
9809a34
Compare
vraja-pro
changed the title
Semrush move links and link params to client side
Semrush move links and link params to client side and tests
Dec 13, 2024
pls78
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR && Acc: ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
For code review
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes Semrush table cleanup and tests