FeatureUpsell story: Allow toggling upsell state within the story #20263
+23
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
FeatureUpsell
to switch between the upsell and non-upsell state.Summary
This PR can be summarized in the following changelog entry:
FeatureUpsell
to switch between the upsell and non-upsell state.Relevant technical choices:
args.shouldUpsell
to allow switching from the Storybook controls.onClick
to an<a>
tag, so that callback needsevent.preventDefault
etc.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
$ yarn workspace @yoast/ui-library storybook
FeatureUpsell
component as expected.Screen.Recording.2023-05-05.at.14.07.30.mov
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label and noted the work hours.Fixes Yoast/ui-library-storybook#12