Merge pull request #160 from Yoast/JRF/minor-fixes

QA/Docs: minor fixes
Yoast · Dec 22, 2023 · a645c87 · a645c87
2 parents b56c9ca + b36948a
commit a645c87
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/Configuration.php b/src/Configuration.php
@@ -20,7 +20,7 @@ class Configuration {
 	/**
 	 * Configuration constructor.
 	 *
-	 * @param array<string> $configuration The configuration to use.
+	 * @param array<string, string> $configuration The configuration to use.
 	 *
 	 * @throws InvalidType When the $configuration parameter is not of the expected type.
 	 */

diff --git a/src/RequirementsChecker.php b/src/RequirementsChecker.php
@@ -44,8 +44,8 @@ class RequirementsChecker {
 	/**
 	 * RequirementsChecker constructor.
 	 *
-	 * @param array<Requirement> $configuration The configuration to check.
-	 * @param string             $textdomain    The text domain to use for translations.
+	 * @param array<string, string> $configuration The configuration to check.
+	 * @param string                $textdomain    The text domain to use for translations.
 	 *
 	 * @throws InvalidType When the $configuration parameter is not of the expected type.
 	 */

diff --git a/tests/Unit/RequirementsCheckerTest.php b/tests/Unit/RequirementsCheckerTest.php
@@ -134,7 +134,7 @@ public function testIfRequirementExists() {
 	 * @return void
 	 */
 	public function testCheckIfPHPRequirementIsNotFulfilled() {
-		$checker = new RequirementsChecker( array( 'php' => 4 ) );
+		$checker = new RequirementsChecker( array( 'php' => '4' ) );
 
 		$checker->addRequirement( new VersionRequirement( 'php', '5.6' ) );
 		$checker->check();
@@ -189,7 +189,7 @@ public function testCheckIfRequirementIsFulfilled() {
 	 * @return void
 	 */
 	public function testCheckIfRequirementIsNotFulfilled() {
-		$checker = new RequirementsChecker( array( 'mysql' => 4 ) );
+		$checker = new RequirementsChecker( array( 'mysql' => '4' ) );
 
 		$checker->addRequirement( new VersionRequirement( 'mysql', '5.6' ) );
 		$checker->check();
@@ -215,7 +215,7 @@ public function testCheckIfRequirementIsNotFulfilled() {
 	 * @return void
 	 */
 	public function testCheckIfRequirementIsFulfilledWithSpecificComparison() {
-		$checker = new RequirementsChecker( array( 'php' => 4 ) );
+		$checker = new RequirementsChecker( array( 'php' => '4' ) );
 
 		$checker->addRequirement( new VersionRequirement( 'php', '5.2', '<' ) );
 		$checker->check();
@@ -233,7 +233,7 @@ public function testCheckIfRequirementIsFulfilledWithSpecificComparison() {
 	 * @return void
 	 */
 	public function testCheckIfRequirementIsNotFulfilledWithSpecificComparison() {
-		$checker = new RequirementsChecker( array( 'php' => 4 ) );
+		$checker = new RequirementsChecker( array( 'php' => '4' ) );
 
 		$checker->addRequirement( new VersionRequirement( 'php', '5.2', '>=' ) );
 		$checker->check();