This repository has been archived by the owner on Oct 4, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a resolutions section to the
package.json
in the root of the monorepo.This
resolution
forcesfsevents
to be version1.2.9
, which is the first version offsevents
that adds support for node v12.You can find more information about yarn's
resolutions
here.This PR can be summarized in the following changelog entry:
fsevents
to version1.2.9
to add node 12 support.Relevant technical choices:
This is a work-around for the real problem, which is that our dependencies are heavily out-dated in some of our packages. Although this PR will allow us to install and build on node v12, we should upgrade our packages to add proper support.
You can check the release cycle for node here. Node 10 will receive updates until 2020-05-19, after which the maintenance period starts (meaning that serious bugs / security flaws will still be fixed). EOL (End-Of-Life) for Node 10 is on 2021-04-30.
The tests in
yoastseo
will fail when using node v12. This is currently also happening in Travis in a test that is allowed to fail.I have created an issue for upgrading the dependencies.
Test instructions
This PR can be tested by following these steps:
nvm
to do this easily)yarn install
fsevents
, although the install will be successful sincefsevents
is optional.yarn install
(if it says "nothing changed" useyarn install --force
)UI changes
Quality assurance
Fixes N/A