Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Add resolutions to package.json #627

Closed
wants to merge 1 commit into from
Closed

Conversation

bintzandt
Copy link
Contributor

Summary

This PR adds a resolutions section to the package.json in the root of the monorepo.

This resolution forces fsevents to be version 1.2.9, which is the first version of fsevents that adds support for node v12.

You can find more information about yarn's resolutions here.

This PR can be summarized in the following changelog entry:

  • [monorepo-root] Force fsevents to version 1.2.9 to add node 12 support.

Relevant technical choices:

  • This is a work-around for the real problem, which is that our dependencies are heavily out-dated in some of our packages. Although this PR will allow us to install and build on node v12, we should upgrade our packages to add proper support.

    You can check the release cycle for node here. Node 10 will receive updates until 2020-05-19, after which the maintenance period starts (meaning that serious bugs / security flaws will still be fixed). EOL (End-Of-Life) for Node 10 is on 2021-04-30.

  • The tests in yoastseo will fail when using node v12. This is currently also happening in Travis in a test that is allowed to fail.

  • I have created an issue for upgrading the dependencies.

Test instructions

This PR can be tested by following these steps:

  • Check-out the develop branch.
  • Switch to node v12 (I use nvm to do this easily)
  • Run yarn install
  • Check that it errors on fsevents, although the install will be successful since fsevents is optional.
  • Switch to this branch
  • Run yarn install (if it says "nothing changed" use yarn install --force)
  • No errors 🎉

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes N/A

@bintzandt bintzandt added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Apr 16, 2020
@bintzandt bintzandt self-assigned this Apr 16, 2020
@bintzandt
Copy link
Contributor Author

Closing this PR because Travis cannot cope with resolutions for Optional Dependencies.

@bintzandt bintzandt closed this Apr 17, 2020
@IreneStr IreneStr deleted the add-fsevents-resolution branch September 17, 2020 06:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant