Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Three new Test Suits Statements, Accessors, and Unary update expressions #181

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

tinkerer-red
Copy link

@tinkerer-red tinkerer-red commented Oct 17, 2024

Support for validating
BasicAccessorExpressionsTestSuite

  • Each kind of accessor expression
  • Each combination of accessors
    BasicStatementExpressionsTestSuite
  • Each kind of structure statement, if, for, with, try, etc.
  • Stacked variants of the same statements
    BasicUnaryUpdateExpressions
  • Unary update expressions for every accessor, and scope type.

@tinkerer-red
Copy link
Author

As a note some code is currently commented out until two different bugs are fixed

YoYoGames/GameMaker-Bugs#7799
YoYoGames/GameMaker-Bugs#8041

@tinkerer-red tinkerer-red marked this pull request as draft October 18, 2024 12:54
@tinkerer-red tinkerer-red marked this pull request as ready for review October 18, 2024 12:56
@DiasFranciscoA
Copy link
Collaborator

DiasFranciscoA commented Oct 18, 2024

The tests shouldn't provide workaround for bugs. They should expose the bugs so we can see when they are fixed. So please, make sure to let the test fail... or if it is a crashing bug.... add a dummy:

assert_true(false, "This code should be uncommented when the bug is fixed!");

so it will not crash but still fail

@tinkerer-red
Copy link
Author

@DiasFranciscoA Having that code uncommented prevents a compile. Additionally it will not be fixed until GMRT as mentioned by Russell YoYoGames/GameMaker-Bugs#8041 (comment)
But you bring up a great point with the assertion there. I'll add that to the tests now

@tinkerer-red tinkerer-red marked this pull request as draft October 18, 2024 23:01
@tinkerer-red tinkerer-red changed the title Added BasicAccessorExpressionsTestSuite Added Three new Test Suits Statements, Accessors, and Unary update expressions Oct 18, 2024
@tinkerer-red tinkerer-red marked this pull request as ready for review October 19, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants