Fix padding of virtual buffers' paths #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yevgnen
reviewed
Jan 3, 2017
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ;; Author: Yevgnen Koh <[email protected]> | |||
| ;; Package-Requires: ((emacs "24.4") (ivy "0.8.0")) | |||
| ;; Package-Version: 20161228.2022 | |||
There was a problem hiding this comment.
The package version is auto generated, so this line is not necessary.
Yevgnen
reviewed
Jan 3, 2017
ivy-rich.el
Outdated
| @@ -209,7 +211,7 @@ Currently the transformed format is | |||
| (format "%s%s%s" | |||
| filename | |||
| ivy-rich-switch-buffer-delimiter | |||
| (ivy-rich-switch-buffer-pad path (- (window-width) (length filename))))) | |||
| path)) | |||
There was a problem hiding this comment.
This line seems not related to issue, and is used for padding all the lines to same length. Can you describe the issue here?
|
Thanks for reporting the issue. Also I find the unexpected delimiter when I've add come comments in your commit, can you please check them when you have time? Thank you! |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Yevgnen,
This fixes padding of virtual buffers' paths, in case the projectile mode isn't installed