New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add analyzers #40

Merged

sarthakn7 merged 15 commits into master from add_analyzers

Feb 6, 2020

Contributor

sarthakn7 commented Feb 4, 2020

Added ability to use predefined Lucene analyzers as well as create custom analyzers.
Note:

ConditionalTokenFilter code would compile fine but it's only implementation needs a file as param. Sending a file as a param (i.e. getting file contents, writing it to a file and then using that as a param) isn't supported yet, so this code is useless right now.
The analyzers for suggest haven't been modified here - just using standard analyzer for now.

sarthakn7 added 8 commits

February 4, 2020 12:25


          Added ability to define custom analyzers

67f438a


          Removed Version object and made generic IntObject

485a72d


          Creating new maps for the params

18e0791


          Added tests for custom analyzer

7a6362a


          Added predefined analyzers

04f5133


          Remove index state as parameter for getAnalyzer

209af3c


          Added the custom analyzer to exception

2f2d5b0


          Corrected condition and using the right enum

a113ecc

sarthakn7 requested a review from umeshdangat

February 4, 2020 21:36


          Added a short description for predefined analyzers

886fef4

umeshdangat reviewed

View reviewed changes

src/main/proto/analysis.proto Outdated Show resolved Hide resolved

umeshdangat reviewed

View reviewed changes

src/main/java/org/apache/platypus/server/luceneserver/AnalyzerCreator.java Outdated Show resolved Hide resolved

umeshdangat reviewed

View reviewed changes

src/main/java/org/apache/platypus/server/luceneserver/AnalyzerCreator.java Outdated Show resolved Hide resolved

umeshdangat reviewed

View reviewed changes

src/main/java/org/apache/platypus/server/luceneserver/BuildSuggestHandler.java Show resolved Hide resolved

umeshdangat reviewed

View reviewed changes

Member

umeshdangat left a comment

looks good, left minor comments

umeshdangat reviewed

View reviewed changes

src/main/java/org/apache/platypus/server/luceneserver/AnalyzerCreator.java Show resolved Hide resolved

sarthakn7 added 5 commits

February 5, 2020 11:34


          Extracted constants for standard and classic

e45efd5


          Refactored analyzer creation for fields

bb0a6fa


          Checking analyzer, searchAnalyzer and indexAnalyzer in hasAnalyzer me…

a28a53e

…thod instead of just checking analyzer


          Using isAnalyzerDefined to check that analyzer is present

36966d3


          Added more tests

3c3934d

This was referenced Feb 5, 2020

Use proper analyzers for suggest instead of just using StandardAnalyzer #45

Open

Support specifying parameters like stopWords and stemExclusions for predefined analyzers #46

Open


          Added some documentation for tokenizer and token filter

14cfae3

umeshdangat approved these changes

View reviewed changes

sarthakn7 merged commit 6e2ce1b into master

sarthakn7 deleted the add_analyzers branch

February 6, 2020 18:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet