Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default joint_state names for single-group #340

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Change default joint_state names for single-group #340

merged 2 commits into from
Dec 19, 2024

Conversation

jimmy-mcelwain
Copy link
Collaborator

As discussed in #331. Omit the "group_N" part of the message if it is a single group.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

yamllint Failed

Show Output 
::group::config/motoros2_config.yaml
::error file=config/motoros2_config.yaml,line=182,col=35::182:35 [trailing-spaces] trailing spaces
::endgroup::

Workflow: CI: lint MotoROS2 config, Action: __karancode_yamllint-github-action, Lint: config

@jimmy-mcelwain
Change default joint_state names for single-group
59475bd 
Omit the "group_1" part of the message if it is a single group.
@jimmy-mcelwain jimmy-mcelwain force-pushed the default_joint_names_single_group branch from da1187f to 59475bd Compare December 6, 2024 19:00
gavanderhoorn
gavanderhoorn reviewed Dec 12, 2024
View reviewed changes
config/motoros2_config.yaml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/ControllerStatusIO.c Show resolved Hide resolved
@jimmy-mcelwain
Update joint name convention notation
429924c 
Update from group_x/joint_y to group_N/joint_M, keeping consistent between the config file and the README
@ted-miller ted-miller added this to the 0.2.0 milestone Dec 19, 2024
@ted-miller ted-miller merged commit b0eff07 into main Dec 19, 2024
5 of 14 checks passed
@ted-miller ted-miller deleted the default_joint_names_single_group branch December 19, 2024 13:49
@gavanderhoorn
Copy link
Collaborator

Note: if no custom joint name configuration is in place, this is a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavanderhoorn gavanderhoorn gavanderhoorn left review comments

@ted-miller ted-miller ted-miller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jimmy-mcelwain @gavanderhoorn @ted-miller