Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iron Irwini support #303

Closed
wants to merge 15 commits into from
Closed

Iron Irwini support #303

wants to merge 15 commits into from

Conversation

ted-miller
Copy link
Collaborator

  • Add project infrastructure
  • Remove remap rules
  • Update documentation

@ted-miller ted-miller added this to the 0.2.0 milestone Sep 6, 2024
@gavanderhoorn
Copy link
Collaborator

Honestly, I'm hesitant to approve this as it basically breaks existing functionality.

I agree with your comment that we should support Iron already, but remaps do see use.

I'm not sure whether having Iron supported without remapping is a good idea.

But I won't block it if you really want to merge it in.

(I would recommend rebasing though, instead of merging in main)

@ted-miller ted-miller mentioned this pull request Sep 6, 2024
8 tasks
@ted-miller
Copy link
Collaborator Author

This passes all my testing.

@ted-miller
Copy link
Collaborator Author

Since Iron Irwini is EOL in a month, we will skip this release and focus on Jazzy, which is LTS.

@ted-miller ted-miller closed this Nov 15, 2024
@ted-miller
Copy link
Collaborator Author

NOTE: The work in iron_wip will be carried forward into the jazzy release

@gavanderhoorn
Copy link
Collaborator

@jimmy-mcelwain @ted-miller: the strtoll(..) implementation -- if really needed -- should ideally go into the posix shim. Not in MotoROS2 itself.

@gavanderhoorn gavanderhoorn mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants