Skip to content

Commit

Permalink
Merge pull request #338 from Yaskawa-Global/note_about_mpGetFBPulsePosEx
Browse files Browse the repository at this point in the history
Add note about `mpGetFBPulsePosEx`
  • Loading branch information
gavanderhoorn authored Nov 27, 2024
2 parents 0f0a510 + 2b7cd8c commit ff9b9cc
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/CtrlGroup.c
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,14 @@ BOOL Ros_CtrlGroup_GetFBPulsePos(CtrlGroup* ctrlGroup, long pulsePos[MAX_PULSE_A
#ifndef DUMMY_SERVO_MODE
// get raw (uncorrected/unscaled) joint positions
LONG status = mpGetFBPulsePos (&sData,&pulse_data);

//TODO: Consider using mpGetFBPulsePosEx. The `ex` version automatically applies
// any needed corrections, such as gravity compensation and cross-axis
// coupling. We're already (manually) applying those corrections, so we don't
// need the `ex` version. But if the next controller generation adds some new
// feature, then we should transition so that we don't have to worry about it.
// See also yaskawa-global/motoros2#199.

if (0 != status)
{
Ros_Debug_BroadcastMsg("Failed to get pulse feedback position: %u", status);
Expand Down

0 comments on commit ff9b9cc

Please sign in to comment.