Skip to content

Commit

Permalink
Add note about mpGetFBPulsePosEx
Browse files Browse the repository at this point in the history
Clarify about why we may want to consider it for future usage.
  • Loading branch information
ted-miller committed Nov 26, 2024
1 parent 0f0a510 commit 96558b1
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/CtrlGroup.c
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,13 @@ BOOL Ros_CtrlGroup_GetFBPulsePos(CtrlGroup* ctrlGroup, long pulsePos[MAX_PULSE_A
#ifndef DUMMY_SERVO_MODE
// get raw (uncorrected/unscaled) joint positions
LONG status = mpGetFBPulsePos (&sData,&pulse_data);

//TODO: Consider using mpGetFBPulsePosEx. The `ex` version automatically applies
// any needed corrections, such as gravity compensation and cross-axis
// coupling. We're already (manually) applying those corrections, so we don't
// need the `ex` version. But if the next controller generation adds some new
// feature, then we should transition so that we don't have to worry about it.

if (0 != status)
{
Ros_Debug_BroadcastMsg("Failed to get pulse feedback position: %u", status);
Expand Down

0 comments on commit 96558b1

Please sign in to comment.