Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed page reload on login #28

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

Swetabh333
Copy link
Contributor

Closes #12

Fix login functionality to work consistently on first attempt

This PR addresses an issue where the login process was inconsistent, often failing on the first attempt but succeeding on subsequent tries. Key changes include:

  • Properly handling asynchronous login in AuthContext
  • Implementing correct error handling in the login process
  • Ensuring state updates are reflected before navigation
  • Preventing premature form submission

These changes resolve the race condition that was causing the inconsistent behavior, resulting in a more reliable login experience for users.

Copy link

vercel bot commented Oct 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dypcetclubs-live ❌ Failed (Inspect) Oct 6, 2024 6:03am

@Swetabh333
Copy link
Contributor Author

@Yash-Ainapure I had to make a new fork , can you check it it works now?

@Swetabh333
Copy link
Contributor Author

Can any of the maintainers tell me what the error is?

@Yash-Ainapure
Copy link
Owner

Can any of the maintainers tell me what the error is?

src/appComponents/ClubLogin.tsx(31,11): error TS1345: An expression of type 'void' cannot be tested for truthiness.
Error: Command "npm run build" exited with 2

Copy link

vercel bot commented Oct 7, 2024

@Swetabh333 is attempting to deploy a commit to the yash-ainapure's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Swetabh333
Copy link
Contributor Author

@Yash-Ainapure is it still failing?

@Yash-Ainapure
Copy link
Owner

@Yash-Ainapure is it still failing?

Wait we'll check it

@Swetabh333
Copy link
Contributor Author

Wait we'll check it

alright

@Yash-Ainapure Yash-Ainapure merged commit a51dc9e into Yash-Ainapure:main Oct 8, 2024
1 of 2 checks passed
@Yash-Ainapure
Copy link
Owner

Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Club admin login page gets refreshed when we enter login button
2 participants