add validations for policy undeployments

YasasRangika · Jan 10, 2024 · 52ea95c · 52ea95c
1 parent 07de543
commit 52ea95c
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/...java/org/wso2/carbon/apimgt/rest/api/publisher/v1/impl/GatewayPoliciesApiServiceImpl.java b/...java/org/wso2/carbon/apimgt/rest/api/publisher/v1/impl/GatewayPoliciesApiServiceImpl.java
@@ -128,9 +128,13 @@ public Response engageGlobalPolicy(String gatewayPolicyMappingId,
             // checks whether the gateway policy mapping exists in the particular gateway
             for (GatewayPolicyDeploymentDTO gatewayPolicyDeploymentDTO : gatewayPolicyDeploymentDTOList) {
                 String gwName = gatewayPolicyDeploymentDTO.getGatewayLabel();
-                if (apiProvider.hasExistingDeployments(organization, gwName)) {
+                boolean isDeployment = gatewayPolicyDeploymentDTO.isGatewayDeployment();
+                if (isDeployment && apiProvider.hasExistingDeployments(organization, gwName)) {
                     RestApiUtil.handleBadRequest("Gateway policy mapping is already deployed in the gateway: " + gwName,
                             log);
+                } else if (!isDeployment && !apiProvider.hasExistingDeployments(organization, gwName)) {
+                    RestApiUtil.handleBadRequest("Gateway policy mapping is not deployed in the gateway: " + gwName,
+                            log);
                 }
             }
             List<OperationPolicyData> operationPolicyDataList = apiProvider.getGatewayPolicyDataListByPolicyId(