try file subject

YajJackson · Mar 20, 2024 · fc345d5 · fc345d5
1 parent a4d0b94
commit fc345d5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/build/index.js b/build/index.js
@@ -31506,7 +31506,8 @@ Message: ${diagnostic.message}`;
       commit_id: pullRequest.head.sha,
       path: relativePath,
       side: "RIGHT",
-      line: diagnostic.range.start.line,
+      subject_type: "file",
+      line: diagnostic.range.end.line,
       body
     });
   }

diff --git a/src/action.ts b/src/action.ts
@@ -118,6 +118,9 @@ async function commentOnPR(
             pullRequest.base.repo.name,
         );
 
+        // This can throw: {"resource":"PullRequestReviewComment","code":"custom","field":"pull_request_review_thread.line","message":"pull_request_review_thread.line must be part of the diff"}
+
+        // https://github.com/YajJackson/example-python-project/pull/2/review_comment/create
         core.info("Creating comment for file: " + relativePath);
         await octokit.rest.pulls.createReviewComment({
             owner: context.repo.owner,
@@ -126,7 +129,8 @@ async function commentOnPR(
             commit_id: pullRequest.head.sha,
             path: relativePath,
             side: "RIGHT",
-            line: diagnostic.range.start.line,
+            subject_type: "file",
+            line: diagnostic.range.end.line,
             body,
         });
     }