Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 320 - UI Alignment and Reduce enemy count #514

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

AayushiJapsare15
Copy link

What does this PR do?

This PR addresses UI alignment and adjusts the enemy count. Previously, the spawnAlien function was called only once, causing the aliens to fall only a single time. With my changes, the enemy count is now adjusted based on the level, resulting in improved falling mechanics.

And for UI a very gamey look is give making the game look more professional and interesting.

Fixes #320

image
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Try all diff levels

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@YadavAkhileshh , could you kindly add the hacktoberfest-accepted and appropriate level labels to my PR? Thank you!

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for thunderous-starlight-9c463d ready!

Name Link
🔨 Latest commit 840c31a
🔍 Latest deploy log https://app.netlify.com/sites/thunderous-starlight-9c463d/deploys/671955849d5484000843c30d
😎 Deploy Preview https://deploy-preview-514--thunderous-starlight-9c463d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for alienid ready!

Name Link
🔨 Latest commit 840c31a
🔍 Latest deploy log https://app.netlify.com/sites/alienid/deploys/671955841dea400008ba71a7
😎 Deploy Preview https://deploy-preview-514--alienid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@YadavAkhileshh YadavAkhileshh merged commit 4f4e784 into YadavAkhileshh:main Oct 24, 2024
11 checks passed
Copy link

🎉🎉 Thank you for your contribution! Your PR #514 has been merged! 🎉🎉

@AayushiJapsare15
Copy link
Author

@YadavAkhileshh please add gssoc-ext , hacktoberfest-accepted and appropriate level label.

@AayushiJapsare15
Copy link
Author

@YadavAkhileshh maybe you forgot to add labels to this pr.
Please add gssoc-ext, hacktoberfest-accepted and level label.

@YadavAkhileshh YadavAkhileshh added gssoc-ext New feature or request hacktoberfest-accepted Hacktoberfest level2 level3 and removed level2 labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext New feature or request hacktoberfest-accepted Hacktoberfest level3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Alignment and Reduce enemy count.
3 participants