Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA/126-signup 회원가입시 약관~ 스낵바 출현하며 가입이 불가한 현상 #169

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

QA/126-signup 회원가입시 약관~ 스낵바 출현하며 가입이 불가한 현상 #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion feature/loginsignup/src/main/java/com/susu/feature/loginsignup/signup/SignUpViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class SignUpViewModel @Inject constructor(
} else {
null
},
termAgreement = uiState.value.agreedTerms,
termAgreement = uiState.value.agreedTerms.filter { it > 0 },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2:

it > 0 이 명확하게 어떤 내용인지 감이 잘 안오네요!
추가로 나중에 약관 동의 항목이 더 생기거나 순서가 바뀌면 예상치 못한 동작을 일으킬 것 같습니다!

it 대신 enum class를 사용하고 it > 0 대신 it != (만14세 이상 enum class) 이렇게 바꾸는거 어떠세요!?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 약관은 서버에서 내려주고 있고, 14세 약관만 로컬에서 사용하는 약관이에요
약관 번호로 체크 여부를 판단하느랴 정수형 번호로 부여되어 있어요
회원가입 시 [1, 2]의 array 형태로 동의한 약관의 번호를 보내줍니다

그래서 서버 응답을 굳이굳이 Enum class로 바꾸어 사용하는 방법은 힘들 것 같고..
100번대부터는 로컬에서 사용하는 약관 번호로 사용하는 방법은 어떨까요?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하 서버에서 이렇게 하는군요 ...
음 .. 서버 응답값을 바꿔주는게 좋겠어요
오늘 서버쪽이랑 얘기해보죠~

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기록) 서버에서 처리하기로 함

),
).onSuccess {
postSideEffect(SignUpEffect.NavigateToReceived)
Expand Down
Loading