메트릭 버그 수정 #83
Merged
메트릭 버그 수정 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comforest
force-pushed
the
feature/fix-metric
branch
from
1843637
to
6c34ea3
Compare
SunwoongH
reviewed
Aug 29, 2024
| } else { | ||
| metricManager.increaseGameCount() |
There was a problem hiding this comment.
P2
core 로직 중 명시적으로 saveGameInfo() 메서드를 호출하는 로직이 존재합니다. 그러면 정상적으로 데이터 수집이 어려워 보이는데 saveGameInfo 로직에서 메트릭을 수집하는 이유를 알 수 있을까요?
There was a problem hiding this comment.
헐 완전 실수 입니다 ㅋㅋㅋ 고칠게요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description ✔
PR Rule ✔
P1: 꼭 반영해주세요 (Request changes)
P2: 적극적으로 고려해주세요 (Request changes)
P3: 웬만하면 반영해 주세요 (Comment)
P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
P5: 그냥 사소한 의견입니다 (Approve)