DRAW-217 플레이 중인 방에 모두 나가면 해당 방 삭제 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comforest
force-pushed
the
feature/DRAW-216
branch
from
1a1fbce
to
f17a4cd
Compare
comforest
force-pushed
the
feature/DRAW-217
branch
from
1ab47a2
to
94b672e
Compare
comforest
force-pushed
the
feature/DRAW-216
branch
from
f17a4cd
to
e7c2f4c
Compare
comforest
force-pushed
the
feature/DRAW-217
branch
from
94b672e
to
c26c3d3
Compare
comforest
force-pushed
the
feature/DRAW-216
branch
from
e7c2f4c
to
79e8aab
Compare
comforest
force-pushed
the
feature/DRAW-217
branch
from
c26c3d3
to
a324046
Compare
comforest
force-pushed
the
feature/DRAW-217
branch
from
87a158b
to
4e455e4
Compare
SunwoongH
changed the title
SunwoongH
approved these changes
Aug 12, 2024
| @@ -65,7 +70,6 @@ internal class MafiaGameRoomService( | |||
|
|
|||
| if (gameInfo.room.players.isEmpty()) { | |||
| mafiaGameRepository.removeGameInfo(gameInfo) | |||
| return | |||
There was a problem hiding this comment.
P5
return 문 제거하신 이유가 따로 있으신걸까요?
There was a problem hiding this comment.
음 먼가 로직상 있어야 할 것 같은데 왜 없어졌을까요 hmm...
다시 추가할게요 ㅋㅋㅋㅋ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira ✔
Description ✔
PR Rule ✔
P1: 꼭 반영해주세요 (Request changes)
P2: 적극적으로 고려해주세요 (Request changes)
P3: 웬만하면 반영해 주세요 (Comment)
P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
P5: 그냥 사소한 의견입니다 (Approve)