DRAW-334 Ping 기반 Health Check 웹소켓 세션 상태 관리 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comforest
reviewed
Sep 23, 2024
Comment on lines
42
to
47
| val session = sessionMap[sessionId] | ||
|
|
||
| session?.let { | ||
| session.ping = true | ||
| } | ||
| } |
There was a problem hiding this comment.
p3. let 으로 null check 하는 것은 권장하지 않습니다.
https://tourspace.tistory.com/208
Suggested change
| val session = sessionMap[sessionId] | |
| session?.let { | |
| session.ping = true | |
| } | |
| } | |
| val session = sessionMap[sessionId] ?: return | |
| session.ping = true | |
| } |
app/websocket/src/main/kotlin/com/xorker/draw/websocket/session/PingManager.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # app/websocket/src/main/kotlin/com/xorker/draw/websocket/session/SessionManager.kt
comforest
approved these changes
Sep 28, 2024
| } | ||
|
|
||
| companion object { | ||
| private const val ALLOWED_DELAY_TIME = 2 |
There was a problem hiding this comment.
p4. 초 단위를 표현하거나 애초에 Duration으로 저장해서 비교 해도 될 것 같아요
Duration이 Comparable을 구현하고 있어서 대소 비교 가 될거에요
| @@ -41,4 +46,10 @@ internal class SessionManager( | |||
| val session = sessionMap.remove(sessionId) ?: return null | |||
| return userIdMap.remove(session.user.id) | |||
| } | |||
|
|
|||
| fun setPing(sessionId: SessionId) { | |||
| val session = sessionMap[sessionId] ?: throw UnSupportedException | |||
There was a problem hiding this comment.
p4. Session Not Found Exception 등을 새로만드는게 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira ✔
Description ✔
PR Rule ✔
P1: 꼭 반영해주세요 (Request changes)
P2: 적극적으로 고려해주세요 (Request changes)
P3: 웬만하면 반영해 주세요 (Comment)
P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
P5: 그냥 사소한 의견입니다 (Approve)