XPR-18 CI CD 세팅 #10
Merged
XPR-18 CI CD 세팅 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunwoongH
reviewed
Jun 16, 2024
Comment on lines
+17
to
+21
| tasks { | ||
| withType<Jar> { enabled = true } | ||
| withType<BootJar> { enabled = false } | ||
| } | ||
|
|
There was a problem hiding this comment.
P3: root build.gradle.kts에 tasks를 추가한 이유를 알 수 있을까요?
There was a problem hiding this comment.
빌드 할 때 Root도 인식해서 BootJar 실패가 되더라구요
| - 'main' | ||
| - 'develop' | ||
| - 'feature/*' | ||
| - 'fix/*' |
There was a problem hiding this comment.
P3: fix는 어떤 경우에 사용되는 브랜치인지 알 수 있을까요?
There was a problem hiding this comment.
아 저는 구분 없이 feature 만 쓰긴 하는데
commit 컨밴션처럼 브렌치도 구분해서 쓰는 분들이 있어서 그냥 작성해둔 브랜치에요
Comment on lines
+36
to
+40
| - name: Upload CI results | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: ci-results | ||
| path: build/ci-results |
There was a problem hiding this comment.
어 result를 출력 해주는 걸로 아는데 저도 잘 모르겠네요 ㅋㅋㅋ ㅎㅎ..
Comment on lines
+44
to
+45
| outputs: | ||
| image: echo ${{ steps.build-image.outputs.image }} |
There was a problem hiding this comment.
P5: 이 부분도 어떤 의도로 작성되었는지 궁금합니다.
There was a problem hiding this comment.
디버깅용 입니다. 이슈가 발생 했을 때 이미지 테그가 랜덤값이다보니 잘 적용 되었는 지 등 알 필요가 있을 때가 있더라구요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira ✔
Description ✔
PR Rule ✔
P1: 꼭 반영해주세요 (Request changes)
P2: 적극적으로 고려해주세요 (Request changes)
P3: 웬만하면 반영해 주세요 (Comment)
P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
P5: 그냥 사소한 의견입니다 (Approve)