-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webscape update #865
Webscape update #865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, but it doesn't work on my machine :)
More specifically, it can't sign in to SIS reliably
dorian can run it now
Co-authored-by: martig7 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far (with the changes I did, look at them and make sure they're good)
Issue
closes #864
Database Changes/Migrations
I updated the web scraper to properly scrape coreqs and prereqs. It should run similarly to before, except parse_runner may or may not need some updating, which will come with the resolution of issue #860
Test Modifications
Tests should be the same as before, just run new_parse.py with any given semester and a test csv will be outputted.
Additional Info
I also added a specific bugfix for a semester from 2021.