Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webscape update #865

Merged
merged 10 commits into from
Apr 12, 2024
Merged

Webscape update #865

merged 10 commits into from
Apr 12, 2024

Conversation

martig7
Copy link
Contributor

@martig7 martig7 commented Feb 14, 2024

Issue

closes #864

Database Changes/Migrations

I updated the web scraper to properly scrape coreqs and prereqs. It should run similarly to before, except parse_runner may or may not need some updating, which will come with the resolution of issue #860

Test Modifications

Tests should be the same as before, just run new_parse.py with any given semester and a test csv will be outputted.

Additional Info
I also added a specific bugfix for a semester from 2021.

@martig7 martig7 requested a review from dorian451 February 16, 2024 21:22
@martig7 martig7 self-assigned this Feb 16, 2024
Copy link
Contributor

@dorian451 dorian451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but it doesn't work on my machine :)
More specifically, it can't sign in to SIS reliably

@martig7 martig7 requested a review from dorian451 March 15, 2024 20:19
Copy link
Contributor

@dorian451 dorian451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far (with the changes I did, look at them and make sure they're good)

@dorian451 dorian451 self-requested a review April 5, 2024 20:32
@dorian451 dorian451 merged commit 9ea3e4c into YACS-RCOS:master Apr 12, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug — Webscraper Pre/Coreq Scraping Broke
3 participants