WIP Pull Request for Issue #7 #8 ( Bryan + Minja) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huangmj7 Please run this updated PR again on your computer. |
|
@Bad-Science @huangmj7 I'm confident I resolved issues #7 & #8. However, I need to format the JSON message. The EventStream class is temporarily printing data to the command line. Right now, I'm making sure to write the data to the websocket. |
|
Hi @Bad-Science, @huangmj7 pointed out that we can have one method within our Plezi class read-in data from the Kafka Consumer class and use the build in Plezi Method |
Bad-Science
reviewed
Jul 25, 2018
app/consumers/courses_consumer.rb
Outdated
|
|
||
| class CourseConsumer < ApplicationConsumer | ||
| def consume | ||
| if ( Object.const_defined?('EventStream') == false ) |
app/consumers/sections_consumer.rb
Outdated
| puts params #print out the single message received | ||
| end | ||
| def consume | ||
| if ( Object.const_defined?('EventStream') == false ) |
There was a problem hiding this comment.
Same here, not sure why we need this check
app/consumers/sections_consumer.rb
Outdated
| if ( Object.const_defined?('EventStream') == false ) | ||
| puts "EventStream class not initialized" | ||
| else | ||
| EventStream.on_message(params) |
There was a problem hiding this comment.
you cannot call on_message, it is called by plezi when a websocket client sends a message to the server, where data is the contents of the message
app/consumers/courses_consumer.rb
Outdated
| if ( Object.const_defined?('EventStream') == false ) | ||
| puts "EventStream class not initialized" | ||
| else | ||
| EventStream.on_message(params) |
There was a problem hiding this comment.
You cannot call on_message, it is called internally by plezi only when the websocket server receives a message from the client.
|
@Bad-Science I'm unsure whether we need the auto_dispatch setting to true. |
|
According to the Plezi.io : "To set up a route to accept websocket connections, our controller must either implement an on_message(data) callback OR be an auto_dispatch enabled controller (more about this powerful feature soon)." ([http://www.plezi.io/docs/websockets#what-are-websockets-skip-if-you-know]). |
|
Status so far: I'm confident that I have Kafka pushing messages to the iodine server and now I just need to fix some bugs so that the client side can view the messages from kafka pub/sub stream. @Bad-Science @huangmj7 |
|
@Bad-Science Next TODO:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7 #8
@Bad-Science: @huangmj7 and I are testing the WebSocket for appropriate functionality atm.