Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues 50, 65 #181

Merged
merged 3 commits into from
Apr 26, 2018
Merged

Issues 50, 65 #181

merged 3 commits into from
Apr 26, 2018

Conversation

colegregory
Copy link
Collaborator

Before submitting this PR:

  • Ensure test coverage is complete
  • Ensure all non-pending tests are passing

Issue(s) addressed:

#50
#65
...

Changes proposed

  • Every section stores an array of periods.
  • Adding on to the section-list component, when show-periods is clicked display the list of periods in the table.

@colegregory colegregory requested a review from kburk1997 April 25, 2018 23:25
kburk1997
kburk1997 requested changes Apr 25, 2018
View reviewed changes
Copy link
Member

@kburk1997 kburk1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code is missing tests, I would suggest adding tests in the SectionDetailComponent and SectionListComponent to appropriately test for changes. Other than that, looks great!

@colegregory colegregory reopened this Apr 26, 2018
kburk1997
kburk1997 approved these changes Apr 26, 2018
View reviewed changes
Copy link
Member

@kburk1997 kburk1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks great!

@kburk1997 kburk1997 merged commit 2fc47d2 into YACS-RCOS:master Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kburk1997 kburk1997 kburk1997 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colegregory @kburk1997