Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Course addition functionality, new YacsStagingService option #176

Merged
merged 4 commits into from
Apr 10, 2018
Merged

Course addition functionality, new YacsStagingService option #176

merged 4 commits into from
Apr 10, 2018

Conversation

kburk1997
Copy link
Member

Before submitting this PR:

  • Ensure test coverage is complete
  • Ensure all non-pending tests are passing

Issue(s) addressed:

#170
#161
Misc build issues

Changes proposed

  • Add course addition functionality
  • Add a staging service as an extension of YacsProdService to allow for testing with a local YACS build.
    • Follow the instructions located in yacs-orchestra to set up YACS on your local machine.
    • In order to get this working you may have to change the port yacs-admin is bound to by typing ng serve --port [new-port].
  • Refactor environment structure to provide class name used for YacsService.

@colegregory colegregory merged commit 56da87a into master Apr 10, 2018
@kburk1997 kburk1997 deleted the issue-170 branch October 8, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colegregory colegregory colegregory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kburk1997 @colegregory