fix: make translate feature mostly work

Xyphyn · Aug 1, 2024 · 19fa06b · 19fa06b
1 parent 4b42e40
commit 19fa06b
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 30 deletions.
diff --git a/bun.lockb b/bun.lockb
diff --git a/src/lib/components/lemmy/post/PostActions.svelte b/src/lib/components/lemmy/post/PostActions.svelte
@@ -8,19 +8,15 @@
     BookmarkSlash,
     BugAnt,
     ChatBubbleOvalLeft,
-    ChatBubbleOvalLeftEllipsis,
     CheckBadge,
     EllipsisHorizontal,
     Eye,
     EyeSlash,
     Flag,
-    GlobeAlt,
-    Home,
     Icon,
     Language,
     Newspaper,
     PencilSquare,
-    Scale,
     ServerStack,
     Share,
     Trash,
@@ -36,12 +32,7 @@
   } from '$lib/components/lemmy/moderation/moderation.js'
   import ModerationMenu from '$lib/components/lemmy/moderation/ModerationMenu.svelte'
   import { profile } from '$lib/auth.js'
-  import {
-    contentView,
-    deleteItem,
-    markAsRead,
-    save,
-  } from '$lib/lemmy/contentview.js'
+  import { deleteItem, markAsRead, save } from '$lib/lemmy/contentview.js'
   import { setSessionStorage } from '$lib/session.js'
   import { goto } from '$app/navigation'
   import { userSettings, type View } from '$lib/settings.js'
@@ -55,11 +46,9 @@
     toast,
   } from 'mono-svelte'
   import { fediseer, type Data } from '$lib/fediseer/fediseer'
-  import Fediseer from '$lib/fediseer/Fediseer.svelte'
   import { t } from '$lib/translations'
   import { text } from '$lib/components/translate/translation'
-  import Translation from '$lib/components/translate/Translation.svelte'
-  import { hidePost, postLink, type MediaType } from './helpers'
+  import { hidePost, type MediaType } from './helpers'
   import { feature } from '$lib/version'
   import Switch from '$lib/components/input/Switch.svelte'
   import { instanceToURL } from '$lib/util'
@@ -92,7 +81,9 @@
 </script>
 
 {#if fediseerData}
-  <Fediseer bind:open={fediseerOpen} data={fediseerData} />
+  {#await import('$lib/fediseer/Fediseer.svelte') then { default: Fediseer }}
+    <Fediseer bind:open={fediseerOpen} data={fediseerData} />
+  {/await}
 {/if}
 
 {#if editing}

diff --git a/src/lib/components/markdown/MarkdownEditor.svelte b/src/lib/components/markdown/MarkdownEditor.svelte
@@ -173,7 +173,7 @@
     class="flex flex-col border border-slate-200 border-b-slate-300 dark:border-t-zinc-700 dark:border-zinc-800
     focus-within:border-primary-900 focus-within:dark:border-primary-100 focus-within:ring ring-slate-300
     dark:ring-zinc-700 rounded-xl
-overflow-hidden transition-colors"
+overflow-hidden transition-colors {$$props.class}"
     class:mt-1={label}
   >
     {#if previewing}

diff --git a/src/lib/components/translate/Translation.svelte b/src/lib/components/translate/Translation.svelte
@@ -34,7 +34,6 @@
     requestURL.searchParams.set('q', text)
     requestURL.searchParams.set('source', from)
     requestURL.searchParams.set('target', to)
-    requestURL.searchParams.set('alternatives', '')
 
     result = fetch(requestURL.toString(), {
       method: 'POST',
@@ -89,24 +88,22 @@
         <Spinner width={32} />
       </div>
     {:then result}
-      {#if !error}
-        <MarkdownEditor
-          previewButton={false}
-          previewing
-          tools={false}
-          rows={8}
-          value={result.translatedText || 'Failed to translate'}
-          disabled
-        ></MarkdownEditor>
-      {/if}
+      <MarkdownEditor
+        previewButton={false}
+        previewing
+        tools={false}
+        rows={8}
+        value={result.translatedText || 'Failed to translate'}
+        disabled
+      ></MarkdownEditor>
     {:catch err}
       <MarkdownEditor
         previewButton={false}
         previewing
         tools={false}
         disabled
         rows={8}
-        value={err || 'Failed to translate'}
+        value="Failed to translate: {err}"
         class="!border-red-500 !ring-red-500 !text-red-500"
       ></MarkdownEditor>
     {/await}

diff --git a/src/lib/components/ui/navbar/Profile.svelte b/src/lib/components/ui/navbar/Profile.svelte
@@ -143,9 +143,18 @@
     <!-- svelte-ignore a11y-no-static-element-interactions -->
     <div class="contents" on:click|stopPropagation={() => {}}>
       <Select bind:value={$colorScheme} class="ml-auto my-auto w-24" size="sm">
-        <option value="system">{$t('nav.menu.colorscheme.system')}</option>
-        <option value="light">{$t('nav.menu.colorscheme.light')}</option>
-        <option value="dark">{$t('nav.menu.colorscheme.dark')}</option>
+        <option value="system">
+          <Icon src={ComputerDesktop} size="16" mini />
+          {$t('nav.menu.colorscheme.system')}
+        </option>
+        <option value="light">
+          <Icon src={Sun} size="16" mini />
+          {$t('nav.menu.colorscheme.light')}
+        </option>
+        <option value="dark">
+          <Icon src={Moon} size="16" mini />
+          {$t('nav.menu.colorscheme.dark')}
+        </option>
       </Select>
     </div>
   </MenuButton>