Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a relative path refernce in a cmake file. #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdownie
Copy link

@jdownie jdownie commented Jul 12, 2023

I was unable to compile in my machine without this change. Hopefully this is a sensible change to offer upstream.

@MrDolch
Copy link

MrDolch commented Jul 29, 2023

I faced the same problem and this commit solved it. Big thanks to @jdownie

@He-Peter-Huang
Copy link

Yes, this fixed the issue. Please merge into main branch.

@jdownie
Copy link
Author

jdownie commented Dec 4, 2023

Is there something else i could or should do to help this into the upstream project @He-Peter-Huang ?

@lbuque
Copy link
Contributor

lbuque commented Dec 4, 2023

@jdownie The problem you encountered may be caused by the incorrect commit id of lcd_binding_micropython. You can try to use https://github.com/lbuque/micropython-builder

@He-Peter-Huang
Copy link

Is there something else i could or should do to help this into the upstream project @He-Peter-Huang ?

I tried pulling micropython to the latest build, no luck, encountered a couple of errors. Could someone try to bump it to the latest version? The new mip seems a lot friendlier than the old upip.

@jdownie
Copy link
Author

jdownie commented Dec 4, 2023

Thanks for the suggestion @lbuque . I think that this means that my solution might have yielded a positive result and helped @He-Peter-Huang , but it's not addressing the root cause. I think @He-Peter-Huang and I are keen to see my PR rejected and the other branch that you volunteered merged so that people like us get the best available version by default instead of getting lost among these branches. Have you submitted a PR for your solution?

@lbuque
Copy link
Contributor

lbuque commented Dec 5, 2023

@jdownie Please check out #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants