-
Notifications
You must be signed in to change notification settings - Fork 818
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
setting a+x to unify permissions across .sh files
- Loading branch information
Showing
8 changed files
with
0 additions
and
0 deletions.
There are no files selected for viewing
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
3f62ed9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only shell scripts which have a shebang should have executable permissions.
The other scripts are only meant to be sourced, not executed.
3f62ed9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we execute those files ... (i.e. not
source ...) ...see: https://github.com/Xilinx/PYNQ/blob/master/sdbuild/scripts/install_packages.sh
3f62ed9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next files gained an executable flag in this commit, but do not have a shebang:
https://github.com/Xilinx/PYNQ/blob/3f62ed93bc5f4056ed944979d0cf56c0ea2bdf03/sdbuild/packages/libsds/qemu.sh
https://github.com/Xilinx/PYNQ/blob/3f62ed93bc5f4056ed944979d0cf56c0ea2bdf03/sdbuild/packages/pandas/qemu.sh
https://github.com/Xilinx/PYNQ/blob/3f62ed93bc5f4056ed944979d0cf56c0ea2bdf03/sdbuild/packages/pynq/boardname.sh
https://github.com/Xilinx/PYNQ/blob/3f62ed93bc5f4056ed944979d0cf56c0ea2bdf03/sdbuild/packages/xrt/xrt_setup.sh
The last two are copied into
/etc/profile.d:And files there should not have the executable flag set either.