This repository has been archived by the owner on Aug 21, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added custom fields to user model #69
base: develop
Are you sure you want to change the base?
added custom fields to user model #69
Changes from 6 commits
c5eec55
f3db20e
234e4ef
be6289d
d4ffef0
b460878
fedd851
1a8ec38
801b72f
9362266
1bda33b
aca92d2
46b5945
f4976e7
cdc2dc0
d9296f4
0445ebc
2bc8353
e38e029
9b24815
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when you create a user/interact outside of application logic boundary, it is no longer a "unit" test; this is an integration test;
You could try using interfaces that mock or rather override functionality so that actual DB operations are mimicked and some stubs take over; we assume that they do certain things and we can define those implementations;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give an example of how we could implement such interfaces in relation to the tests shown above, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I need to rewrite the tests, or are we proceeding with the currently written tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the program is not accessing anything outside its own boundary; if you can run a Django test in flight mode with no SQL/NoSQL connected, then its a unit test;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I still work on this or will this not be applicable for the new repo?