Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix runtime not appearing when multiple runtimes exist for same build #523

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

MattKiazyk
Copy link
Contributor

Fixes issue where iOS 17.4 runtime was not showing on Xcode 15.3

This was because we were grabbing only the first option (naïvely thinking that there would be a singular platform per release) and instead set the sdkToSimulatorMappings to an array.

This allows 17.4 to show properly.

@MattKiazyk MattKiazyk added the bugfix Fixes a bug label Mar 8, 2024
@MattKiazyk MattKiazyk merged commit 238ac71 into main Mar 8, 2024
1 check passed
@MattKiazyk MattKiazyk deleted the fix-missing-runtime branch March 8, 2024 20:46
@rtharston
Copy link

Wow, nice timing on this!
I was going to report this but then I decided to fork and try and fix it myself instead of just logging an issue. Then I built locally and the problem was gone. Lo and behold, you merged this right before I forked! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants