Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n(zh-Hant): Update translation for 2.0.2 #502

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

pan93412
Copy link
Contributor

@pan93412 pan93412 commented Feb 9, 2024

This PR completes the translation of zh-Hant (100%), unifies the terms (such as '拷貝'), and reviews the current translation.

r? @itszero @toto6038 [done]

Copy link
Contributor

@itszero itszero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@MattKiazyk
Copy link
Contributor

@pan93412 with one Localizable file now conflicts happen all the time. Can you rebase and I'll get that merged in. Thanks

@pan93412
Copy link
Contributor Author

Sure. Hold on.

@pan93412 pan93412 marked this pull request as draft February 17, 2024 19:05
@pan93412 pan93412 force-pushed the l10n/zh-TW/230210 branch 2 times, most recently from 53895be to c4bd1d2 Compare February 18, 2024 09:35
@pan93412 pan93412 marked this pull request as ready for review February 18, 2024 09:54
@pan93412
Copy link
Contributor Author

@pan93412 with one Localizable file now conflicts happen all the time. Can you rebase and I'll get that merged in. Thanks

Done. Besides, I make a tool that makes the merge easier, you can take a look at https://github.com/pan93412/string-catalog-merger :)

@pan93412 pan93412 marked this pull request as draft February 19, 2024 00:22
@pan93412 pan93412 marked this pull request as ready for review February 19, 2024 00:31
@pan93412
Copy link
Contributor Author

pan93412 commented Mar 5, 2024

How about this? cc @MattKiazyk

@MattKiazyk MattKiazyk added the localization Chore and new localizations label Mar 8, 2024
@MattKiazyk
Copy link
Contributor

Thanks!

@MattKiazyk MattKiazyk merged commit e9a95a3 into XcodesOrg:main Mar 8, 2024
1 check passed
@pan93412 pan93412 deleted the l10n/zh-TW/230210 branch May 27, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Chore and new localizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants