Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation progress bar to dock icon #423

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

senmu
Copy link
Contributor

@senmu senmu commented Sep 15, 2023

Closes #17

Uses suggested DockProgress to display a progress bar overlay on top of the dock icon as an Xcode is downloading.

Successor to #85. A new overallProgress has been pulled up to track the downloading and the unarchive portion of installing an Xcode. Within the overallProgress the following weights are applied:

  • 90% of the overall progress is allocated to the download
  • The remaining 10% is allocated to the unarchive step
    • This is tracked in a binary fashion (incomplete or complete) as no progress is provided in any sort of callback during the unarchive process

Below are some previews:

During download

Screenshot 2023-09-14 at 13 06 35

During unarchiving

Screenshot 2023-09-14 at 13 09 28

During the post-installation/finishing steps

These final steps require user interaction so no new child Progress objects were created to track these. However, you can see that once it gets here, the progress bar is gone.

Screenshot 2023-09-14 at 13 24 18

to track both downloading and unarchiving and reflect this in dock progress
@senmu
Copy link
Contributor Author

senmu commented Sep 19, 2023

I needed to update the CI workflow to use Xcode 14.2 via b6e654c as building failed (see 622fac6) on 13.2.1

@MattKiazyk MattKiazyk added the enhancement New feature or request label Nov 22, 2023
@MattKiazyk MattKiazyk merged commit 5edeb60 into XcodesOrg:main Nov 22, 2023
1 check passed
@MattKiazyk
Copy link
Contributor

Thanks a bunch @senmu (sorry for the late response)

@senmu senmu deleted the sam/dockProgress branch November 30, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display aggregate installation progress in dock icon
2 participants