actions: Create release on push #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me @mborgerson |
GXTX
reviewed
Dec 21, 2021
.github/workflows/CI.yml
Outdated
| pushd dist/extract-xiso_Win32_Debug | ||
| zip -r ../extract-xiso-win32-debug.zip * | ||
| popd | ||
| pushd dist/extract-xiso_Win64_Release |
There was a problem hiding this comment.
Should the win64 builds be commented out for now as #29 still applies?
There was a problem hiding this comment.
I agree, let's comment this out and not distribute broken 64b builds for now
mborgerson
reviewed
Dec 30, 2021
.github/workflows/CI.yml
Outdated
| # asset_name: extract-xiso-win64-debug.zip | ||
| # asset_path: dist/extract-xiso-win64-debug.zip | ||
| # asset_content_type: application/zip | ||
| - name: Upload release assets (macOS build) |
There was a problem hiding this comment.
Let's also not distribute these 64b Mac builds until 64b is fixed
There was a problem hiding this comment.
Done, updated comments accordingly.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.