[WIP] Refactor plugin template #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh146
approved these changes
Oct 22, 2019
There was a problem hiding this comment.
This is great, and much more flexible, thanks @johannesjmeyer!
|
I just noticed that it is still WIP; let me know when it is review ready and I'll look over any additional changes. |
|
Any plans to merge this PR @josh146 ? |
|
Oh, that would have probably been useful for my new plug-in 😅 But I think we should actually have a way to integration test plugins with code inside pennylane that is kept up to date at all times (it's always hard to keep all the plugins and the template up to date). Maybe we could have a functionality to integration test a plug-in with default.qubit as the normal?
I.e. something useable as
```
@pytest.mark.parametrize(*qml.test.parametrization("my device")
def test(args):
qml.test.case(args)
```
where test.case returns a sensible error message.
|
|
I agree. The tests in the plugin-template repo are pretty much useless if you want to make a device using Worth fixing the random mentions of qiskit/forest though 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some minor refactoring in the plugin itself and some major changes that make the plugin template tests more flexible.