-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Real interferometer #132
Real interferometer #132
Conversation
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 68.70% 70.41% +1.70%
==========================================
Files 26 26
Lines 2732 2687 -45
==========================================
+ Hits 1877 1892 +15
+ Misses 855 795 -60
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ziofil, this is looking good from my side! ✨ I left some small suggestions and questions on the implementation.
On the testing side, I found a pattern related to making tests deterministic that was common in SF and perhaps we could try to avoid bringing into Mr Mustard. 🔍
Co-authored-by: Sebastián Duque Mesa <[email protected]>
Co-authored-by: Sebastián Duque Mesa <[email protected]>
Co-authored-by: Sebastián Duque Mesa <[email protected]>
Co-authored-by: Sebastián Duque Mesa <[email protected]>
Co-authored-by: Sebastián Duque Mesa <[email protected]>
Co-authored-by: Sebastián Duque Mesa <[email protected]>
Context:
It would be nice to have a trainable real interferometer (i.e. one that doesn't mix q and p)
Description of the Change:
I added a new gate:
RealInterferometer
Benefits:
We have it now :)
Possible Drawbacks:
None
Related GitHub Issues:
None