Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real interferometer #132

Merged
merged 24 commits into from
May 18, 2022
Merged

Real interferometer #132

merged 24 commits into from
May 18, 2022

Conversation

ziofil
Copy link
Collaborator

@ziofil ziofil commented May 13, 2022

Context:
It would be nice to have a trainable real interferometer (i.e. one that doesn't mix q and p)

Description of the Change:
I added a new gate: RealInterferometer

Benefits:
We have it now :)

Possible Drawbacks:
None

Related GitHub Issues:
None

@ziofil ziofil requested a review from sduquemesa May 13, 2022 21:31
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #132 (4f081a9) into main (8902144) will increase coverage by 1.70%.
The diff coverage is 89.18%.

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   68.70%   70.41%   +1.70%     
==========================================
  Files          26       26              
  Lines        2732     2687      -45     
==========================================
+ Hits         1877     1892      +15     
+ Misses        855      795      -60     
Impacted Files Coverage Δ
mrmustard/utils/training.py 81.96% <ø> (-1.11%) ⬇️
mrmustard/lab/gates.py 91.77% <85.71%> (-0.43%) ⬇️
mrmustard/math/math_interface.py 96.64% <93.33%> (+18.48%) ⬆️
mrmustard/lab/states.py 98.00% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8902144...4f081a9. Read the comment docs.

Copy link
Contributor

@sduquemesa sduquemesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ziofil, this is looking good from my side! ✨ I left some small suggestions and questions on the implementation.

On the testing side, I found a pattern related to making tests deterministic that was common in SF and perhaps we could try to avoid bringing into Mr Mustard. 🔍

mrmustard/lab/gates.py Outdated Show resolved Hide resolved
mrmustard/lab/gates.py Outdated Show resolved Hide resolved
mrmustard/lab/gates.py Outdated Show resolved Hide resolved
mrmustard/lab/gates.py Outdated Show resolved Hide resolved
mrmustard/lab/gates.py Outdated Show resolved Hide resolved
tests/test_utils/test_opt.py Show resolved Hide resolved
tests/test_utils/test_opt.py Show resolved Hide resolved
tests/test_utils/test_opt.py Show resolved Hide resolved
tests/test_utils/test_opt.py Show resolved Hide resolved
mrmustard/math/math_interface.py Show resolved Hide resolved
ziofil and others added 8 commits May 17, 2022 14:47
Co-authored-by: Sebastián Duque Mesa <[email protected]>
Co-authored-by: Sebastián Duque Mesa <[email protected]>
Co-authored-by: Sebastián Duque Mesa <[email protected]>
Co-authored-by: Sebastián Duque Mesa <[email protected]>
Co-authored-by: Sebastián Duque Mesa <[email protected]>
Co-authored-by: Sebastián Duque Mesa <[email protected]>
@ziofil ziofil merged commit 76bd719 into main May 18, 2022
@ziofil ziofil deleted the real_interferometer branch May 18, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants