Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XML RPC] Fix unstable connection when trying to establish connection between publisher and subscriber #2

Closed
wants to merge 1 commit into from
Closed

[XML RPC] Fix unstable connection when trying to establish connection between publisher and subscriber #2

wants to merge 1 commit into from

Conversation

wijanarko-sukma
Copy link

Fix #46

@andreaskoepf
Copy link
Member

Thank for the PR! I am starting today with a rewrite of core-parts of the ROS.net communication system in order to address some problems that we noted. I hope as part of this I will also find time to test the connection-close impact.

@andreaskoepf
Copy link
Member

@wijanarko-sukma Could you tell under which conditions this Connection: Close fix became neccassary? I would like to reproduce the issue if possible.

@andreaskoepf
Copy link
Member

I will close this for now. There was a bug that prevented correct closing of connections. Even without Connection: Close it ran stable in tests on my machine. Nevertheless thanks for submitting the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wijanarko-sukma @andreaskoepf