-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sqlcommenter in span #177
base: main
Are you sure you want to change the base?
Sqlcommenter in span #177
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
=====================================
Coverage 80.5% 80.6%
=====================================
Files 13 13
Lines 716 717 +1
=====================================
+ Hits 577 578 +1
Misses 115 115
Partials 24 24
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LeonPev, Thanks for the PR.
Could you please attach examples and screenshots that shows SQL comment in spans?
Please also change ExecContext
and PrepareContext
for consistency. And, update tests and CHANGELOG.md
to reflect this change.
Hi @LeonPev, do you still have an interest in implementing this? I can take this if you are not interested. |
added sqlcommenter output to the sql.conn.query span for compatibility with js and py packages that have similar behavior