Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ulid #100

Merged
merged 12 commits into from
Oct 31, 2023
Merged

Feature/ulid #100

merged 12 commits into from
Oct 31, 2023

Conversation

mambax7
Copy link
Contributor

@mambax7 mambax7 commented May 19, 2023

No description provided.

@mambax7 mambax7 requested a review from geekwright May 19, 2023 10:11
Copy link
Collaborator

@geekwright geekwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat!

Can you add a couple of tests?

  • generate 2 ULIDs and compare to assert they are unequal
  • generate 2 ULIDs and sort to verify they collate properly

Looks good!

@mambax7
Copy link
Contributor Author

mambax7 commented May 20, 2023

OK, done!

@mambax7
Copy link
Contributor Author

mambax7 commented Oct 2, 2023

Richard, did you get a chance to look into it?

src/Ulid.php Outdated Show resolved Hide resolved
@mambax7 mambax7 requested a review from geekwright October 3, 2023 02:28
@mambax7
Copy link
Contributor Author

mambax7 commented Oct 3, 2023

Please see the latest changes

@mambax7
Copy link
Contributor Author

mambax7 commented Oct 3, 2023

FYI - here the tests fail on PhpUnit 7.1, and 7.4, but on my PHPUnit 9.6.13 they passed

@mambax7 mambax7 requested review from ggoffy and GregMage October 31, 2023 16:00
@mambax7 mambax7 merged commit 92a66fb into XOOPS:master Oct 31, 2023
6 checks passed
@mambax7 mambax7 deleted the feature/ulid branch October 31, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants