Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Advanced tools USD notional is incorrect for some tokens #1025

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

danielisaacgeslin
Copy link
Contributor

@danielisaacgeslin danielisaacgeslin commented Aug 16, 2024

[bug] Advanced tools USD notional is incorrect for some tokens

  • Makes different api calls to coingecko depending on the token being native or not
  • Hardcoded coingecko id maps is no longer needed (support for new tokens)

native token
image
image

non native token
image
image

src/utils/telemetry.ts Show resolved Hide resolved
@danielisaacgeslin danielisaacgeslin merged commit 090cd7a into advanced-tools Aug 20, 2024
8 checks passed
@sebastianscatularo sebastianscatularo deleted the bug/USD-notional-some-tokens branch August 30, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants