Fix linter check for black and isort not failing when changes required #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- black and isort returncode is 0 when fixes required and applied, so add arguments that make it returncode 1 when fixes required - flake8 and pycodestyle return 1 already
lognaturel
approved these changes
Nov 29, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noted here.
Linters
blackandisortreturncode is 0 when fixes required and applied, so add arguments that make it returncode 1 when fixes required. Lintersflake8 andpycodestyle` return 1 already.Why is this the best possible solution? Were any other approaches considered?
It's the required arguments
What are the regression risks?
None, only relevant for GitHub actions
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
testsnosetestsand verified all tests passblack pyxform teststo format code