Skip to content

Commit

Permalink
fix: update data files and build script
Browse files Browse the repository at this point in the history
There was an issue in the data script regarding skill indirections. This
was fixed and an update to the data files has been made.

Fixes #24
  • Loading branch information
SargoDarya committed Jul 28, 2022
1 parent aaf5d02 commit f9530e8
Show file tree
Hide file tree
Showing 6 changed files with 81 additions and 13 deletions.
4 changes: 2 additions & 2 deletions bin/build-data-file.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ class XIVApi {
actionIds = [
...actionIds,
...job.GameContentLinks.ActionIndirection.ClassJob.map((id) => {
return actionIndirections[ id ].Name.ID;
return actionIndirections[ id ]?.Name?.ID || null;
})
]
].filter((id) => id !== null)
}

const filters = [
Expand Down
82 changes: 74 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
"@popperjs/core": "^2.9.3",
"@types/jasmine": "~3.8.0",
"@types/node": "^12.11.1",
"axios": "^0.27.2",
"axios-rate-limit": "^1.3.0",
"jasmine-core": "~3.8.0",
"karma": "~6.3.0",
"karma-chrome-launcher": "~3.1.0",
Expand Down
2 changes: 1 addition & 1 deletion src/assets/actionindirections.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/assets/classjobactions.json

Large diffs are not rendered by default.

Loading

0 comments on commit f9530e8

Please sign in to comment.