Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Enemy Protocol granting additional hacking bonuses equal to temporary hacking stat boosts #1449

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BlackDog86
Copy link
Contributor

Fixes #1350

@BlackDog86 BlackDog86 self-assigned this Jan 6, 2025
Copy link
Contributor

@Iridar Iridar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this looks good, needs testing in modded environment.

@@ -297,8 +297,11 @@ function ApplyEnemyProtocol(XComGameState_Unit Hacker, XComGameState_BaseObject
local XComGameState_Unit HackerState;

HackerState = XComGameState_Unit(NewGameState.ModifyStateObject(class'XComGameState_Unit', Hacker.ObjectID));

HackerState.SetBaseMaxStat(eStat_Hacking, HackerState.GetMaxStat(eStat_Hacking) + ENEMY_PROTOCOL_HACKING_BONUS);
// Single Line for Issue #1443 - Use GetBaseStat instead of GetMaxStat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In cases where you provide HL-Docs, it's better to use Start / End Issue tags, so it goes like this:

// Start Issue X
/// HL-Docs: blah
/// blah blah

// End Issue X

@Iridar Iridar added the waiting-on-author A pull request is waiting on changes from the author label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-basegame waiting-on-author A pull request is waiting on changes from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enemy Protocol Hack Reward also grants a permanent hack bonus equal to current temporary Hack stat modifiers
2 participants