Fix for erroneous burst-fire effect stacking #1448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackDog86
changed the title
BlackDog86
changed the title
|
Looks fine, but please use per-line comments to comment out code, the |
BlackDog86
force-pushed
the
1380-BurstFire-Stacking-Fix
branch
from
887c081 to
3b87511
Compare
Iridar
reviewed
Jan 9, 2025
| } | ||
| } | ||
| } | ||
| // Start Issue #1380 - Since onRefresh is be called for each burst-fire shot, we don't need to adjust the |
There was a problem hiding this comment.
Thar be a typo / skipped words in the docs. Two, actually.
Iridar
added
waiting-on-author
BlackDog86
force-pushed
the
1380-BurstFire-Stacking-Fix
branch
2 times, most recently
from
732eb23 to
66123df
Compare
BlackDog86
added
ready-to-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1380
Tested with Knife rounds from MZ Perk pack (which applies 1 stack of bleeding @ 1 damage per instance) combined with Fan Fire and Cyclic Fire from the LW2 Gunner class pack. Correct amount of stacks seem to be applied - further testing required but looks good so far.