-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
once-common-structs
and once-connection-type
#80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome -- yeah, this should definitely be the default and it's a great refactor of the generated output. We can make it the default in another PR
Let's do this for the tests:
Add a second table to the schema and also remove all fields from the tables except maybe an ID, similar to my comment for #82
9c058fc
to
d5fe2e6
Compare
added a second table and rebased onto main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add another test for these options + the single-model-file option but if we're thinking of making these the default, it should be okay to ship this!
Again, thanks for this great refactor of the generated code
added with 007ace8 (all options together), i didnt have a better name for the folder though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thank you @hasezoey
This PR adds options
once-common-structs
andonce-connection-type
These options are currently NOT the default
to make them default, should they still be a option or should it be unconfigurable? also i dont think
no-once-connection-type
orno-once-common-structs
sounds good, any suggestions?re #56