Refactor GenerationConfig to be able to use Default
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
force-pushed
the
refactorGenerationConfig
branch
from
f65509b to
c1f5e3b
Compare
and fix resulting privacy errors
hasezoey
force-pushed
the
refactorGenerationConfig
branch
from
c1f5e3b to
766a794
Compare
|
refactored for #126, i had to use the double- EDIT: also added a changelog entry |
by separating out option fields from required fields and using supporting top-level builder pattern fixes Wulf#92
hasezoey
force-pushed
the
refactorGenerationConfig
branch
from
766a794 to
1a88081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
GenerationConfigto supportDefaultwhere possible by separating out required and optional fields and supporting a top-level builder. (as suggested as point 3 and hybrid-approach of point 3)in addition this PR also:
#[inline]attribute for opaque / trivial functionsfixes #92