-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some things that were broken #112
Conversation
as this pr is a collection of fixes, i added some things i noticed while doing #114, namely:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Let's merge this in instead of #104
I'm going to add a few more commits here which should take care of some of the chnages which weren't included from #104 |
which was broken for "once-connection-type" re Wulf@cc0ecf2
diesel does not have "diesel::PgConnection", only in "::prelude" or "::pg"
fixes mismatch between a tables imports and the directory structure
…ig and binary help
rebased on latest main, and added the as for |
This PR is a small collection of fixes from #104, but refactored to current state dsync and separate from the other changes and not being based on #103, in more detail:
type ConnectionType
be public (was broken foronce-connection-type
)serde::
instead of requiring it to be imported (was broken foronce-common-structs
)these things would likely be catched earlier if the tests would actually be compile tested