Use IBufferDistributedCache for caching HTTP requests #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will greatly reduce the memory usage for caching so that it will be able to stream it better.
twsouthwick
force-pushed
the
better-caching
branch
from
2f6c5fb to
58cce71
Compare
twsouthwick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main thing we need to cache are the HTTP calls downstream. This replaces the previous caching mechanism with an HTTP delegating handler that will cache calls to registered hosts. This uses the new
IBufferDistributedCacheAPI with the recyclable memorystream to greatly reduce allocations of new arrays (and potentially large GC collections) by pooling the buffers and not needing tonewup large arrays manually.