Comments: Prevent comment revert when context menu is open when Escape key gets pressed. #7786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, in Firefox and Safari, pressing the Escape key while the context menu was open (activated by right-clicking) inside the comments form in the comments menu of wp-admin would close both the context menu and the comment form. This resulted in the removal of the written comment, forcing the user to rewrite it.
How was it fixed?
By using the
contextmenu
event, I was able to manage the state that controls the closing of the comment form when the context menu is open.Screencast of the fix:
62346-bug.mov
Trac ticket: https://core.trac.wordpress.org/ticket/62346
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.