-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix writingMode support in dynamic blocks #7534
Fix writingMode support in dynamic blocks #7534
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up @andrewserong 👍
This tests well for me:
I only have a minor question around whether we need a @since
comment at all for this one in the docblock.
Thanks for the reviews, everyone! 🙇 Committed in r59199. |
Add writingMode to the style engine, to support dynamic blocks. This backports some PHP changes that were missed in previous WP core releases:
writing-mode
as a safe CSS property gutenberg#54581For the issue this resolves, see: WordPress/gutenberg#65910
Trac ticket: https://core.trac.wordpress.org/ticket/62189
This PR adds support for the writing mode (orientation) typography block support for dynamic blocks, such as the Site Title block. Without this change, currently (in WP 6.7 Beta 1 and Beta 2) if you go to update the Site Title block and give it a vertical orientation, it'll look fine within the site editor, but still display as horizontal on the site frontend.
To test this PR, open up the site editor, select the site title block, and switch its text orientation in the block inspector to be vertical. Save the template, and view the site frontend. Here is a quick screenshot to show where to update the text orientation (writing mode):
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.