Editor: Make asset registration .asset.php optional for blocks

[josephfusco]

It is a hard requirement that a *.asset.php file is present to register a block in WordPress. Otherwise, it throws a Warning:

function register_block_script_handle was called incorrectly. The asset file (/wp-content/uploads/faustwp/blocks/block-a/index.asset.php) for the "editorScript" defined in "create-block/block-a" block definition is missing. (This message was added in version 5.5.0.)

and the block will not appear in the inserter.

Trac ticket: https://core.trac.wordpress.org/ticket/60460

Gutenberg issue: WordPress/gutenberg#57234

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[github-actions]

Hi @josephfusco! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

• PHP Coding Standards
• CSS Coding Standards
• HTML Coding Standards
• JavaScript Coding Standards
• Accessibility Coding Standards
• Inline Documentation Standards

Thank you,
The WordPress Project

[gziolo]

Resharing my WordPress/gutenberg#57234 (comment) from the issue in the Gutenberg repository. I propose that we remove the handling for the missing asset file and provide the default values instead. To land this patch, the required changes would be removing the proposed filter, and the _doing_it_wrong handling. It would be great to add a unit test that covers the case when there is no asset file provided.

[colorful-tones]

It looks like unit tests are failing. I do not have the knowledge to fix or write 'em. Would it be necessary for merging, and could we have a separate follow-up PR to address the tests @gziolo ?

[colorful-tones]

Also, would it be easier to move this patch to be against the Gutenberg repo?

[josephfusco]

A lot of the failing tests were fixed with 5c67d33, however there are still a few tests failing but seem unrelated.

Also, would it be easier to move this patch to be against the Gutenberg repo?

If the code for register_block_script_handle is sourced from outside of wordpress-develop, I'm happy to move this patch there.

[gziolo]

Thank you for iterations. All changes need to get applied in WordPress core.

[colorful-tones]

Nice progress here @josephfusco ! 🕺

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props joefusco, gziolo, spacedmonkey, colorful-tones.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: josephfusco <[email protected]>
Co-authored-by: gziolo <[email protected]>
Co-authored-by: spacedmonkey <[email protected]>
Co-authored-by: colorful-tones <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[gziolo]

Updating code directly on GitHub isn't the best idea after all 😅

The good news is that it's ready to go!

[gziolo]

Committed with https://core.trac.wordpress.org/changeset/57559.

[colorful-tones]

Thanks for getting this over the line @gziolo and thanks @josephfusco for kicking it off 🙌