Sync: Fix Appearance > Template Parts URL #4142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
commented
Feb 28, 2023
src/wp-admin/menu.php
Outdated
| @@ -210,7 +210,7 @@ | |||
| $submenu['themes.php'][6] = array( | |||
| __( 'Template Parts' ), | |||
| 'edit_theme_options', | |||
| 'site-editor.php?postType=wp_template_part', | |||
| 'site-editor.php?postType=wp_template_part&path=/wp_template_part/all', | |||
There was a problem hiding this comment.
If I remember correctly, there's no need to escape static strings.
There was a problem hiding this comment.
No need to escape this string as it is not exposed to user edits, indeed.
hellofromtonya
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
- Confirmed the PR includes the change from Gutenberg PR 48343 ✅
- Able to reproduce the issue ✅
- Confirmed this patch fixes the issue ✅ (See Test Report)
- Code is consistent with multiple args in this file ✅
Ready for commit 👍
|
Committed via https://core.trac.wordpress.org/changeset/55435. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg PR: WordPress/gutenberg#48343
Trac ticket: https://core.trac.wordpress.org/ticket/57819